test: assert line numbers of evaluated source - #6169
Open
espressolee wants to merge 2 commits into
Open
Conversation
pybind#6089 dropped the coding cookie prepended to py::eval/py::exec source, which had shifted reported SyntaxError and traceback line numbers by one, and noted that no test asserted on them. Add one: errors on line 2 of the evaluated source must report line 2. With pybind11's own test target the new test reports (3, 3) against the parent of pybind#6089 and (2, 2) with the fix. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression coverage for #6089: a
SyntaxErrorand an exception traceback originating on line 2 of evaluated source must both report line 2.Checked with pybind11's own test target (
PYBIND11_TEST_OVERRIDE=test_eval.cpp, CPython 3.12.13, macOS arm64, Apple clang 21):test_evalpasses at current master, and witheval.hfromf00aa6fe(the parent of #6089) only the new test fails, reporting(3, 3).