fix: bring crameri up to spec with v8 - #143
Open
tlambert03 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 168 168
Lines 2186 2188 +2
=======================================
+ Hits 2089 2091 +2
Misses 97 97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing with #141 ... this brings crameri to complete parity with the current v8 data on zenodo. and adds a parity test:
__source__pins to the 8.0.1 deposit (zenodo 8409685) — those tables are byte-identical in both deposits, so that part is metadata only.All 40 crameri maps are now bit-exact against SCM 8.0.1. Adds
test_crameri_data_parity(oracle: cmcrameri 1.10, which vendors the samedeposit) so this can't drift again.