-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add aod and clearsky_index to glossary, link terms in spectrum.rst
#2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
echedey-ls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sexy PR @RDaxini , thanks. Some observations down below, but I'm okay with current status as is.
| clearsky_index | ||
| clearsky index. Ratio of actual global irradiance to modeled clearsky | ||
| global irradiance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various ideas:
-
Citing https://ebrary.net/183058/environment/clear_index:
The clear-sky index is sometimes called cloud modification factor. It is dimensionless. Kc varies between 0 and 1. The greater the attenuation of the radiation by the clouds, the smaller Kc.
I find it interesting this naming variant (I think it's uncommon in PV but may be of interest for newcomers from other engineering areas).
-
Maybe the formula?
:math:`K_C = \frac{GHI_\text{actual}}{GHI_\text{clear-sky}}` -
Maybe note that can either be used with irradiation too?
-
An admonition to distinguish it from clearness index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for "An admonition to distinguish it from clearness index"
| aod | ||
| aod500 | ||
| aerosol optical depth. Measure of aerosols (e.g., smoke | ||
| particles, desert dust) distributed within a column of air from the | ||
| instrument (Earth's surface) to the top of the atmosphere. The AOD | ||
| value indicates the level of extinction of sunlight in this column, and | ||
| when followed by a number (e.g. AOD500), indicates the extinction at | ||
| this wavelength (500nm). [unitless] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it described by these equations? https://en.wikipedia.org/wiki/Optical_depth#Spectral_optical_depth
I have trouble finding PV specific information on a mathematical relationship. At least that is the only missing piece for me.
| value indicates the level of extinction of sunlight in this column, and | ||
| when followed by a number (e.g. AOD500), indicates the extinction at | ||
| this wavelength (500nm). [unitless] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest moving [unitless] to follow aerosol optical depth [unitless].
| clearsky_index | ||
| clearsky index. Ratio of actual global irradiance to modeled clearsky | ||
| global irradiance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for "An admonition to distinguish it from clearness index"
| Zenith angle of the sun in degrees. This is the angle between is | ||
| between a vector pointed straight up and a vector pointed at the sun, | ||
| from the observer. This is the complement of solar elevation | ||
| 90 - elevation). [°] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Zenith angle of the sun in degrees. This is the angle between is | |
| between a vector pointed straight up and a vector pointed at the sun, | |
| from the observer. This is the complement of solar elevation | |
| 90 - elevation). [°] | |
| Zenith angle of the sun in degrees [°]. Zenith is the angle between is | |
| between a vector pointed straight up and a vector pointed at the sun, | |
| from the observer. Zenith is the complement of solar elevation, i.e., | |
| zenith = 90 - elevation. |
Since we're editing this definition.
| observer. The pvlib-python convention is defined as degrees East of | ||
| North, so North = 0°, East = 90°, South = 180°, West = 270°. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| observer. The pvlib-python convention is defined as degrees East of | |
| North, so North = 0°, East = 90°, South = 180°, West = 270°. | |
| observer. Azimuth is defined as degrees East of | |
| North, so North = 0°, East = 90°, South = 180°, West = 270°. |
| Azimuth angle of the surface in degrees East of North. This angle | ||
| describes the horizontal projection of the normal vector from the | ||
| surface. The pvlib-python convention is defined as degrees East | ||
| (clockwise) of North, so North = 0°, East = 90°, South = 180°, | ||
| West = 270°. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Azimuth angle of the surface in degrees East of North. This angle | |
| describes the horizontal projection of the normal vector from the | |
| surface. The pvlib-python convention is defined as degrees East | |
| (clockwise) of North, so North = 0°, East = 90°, South = 180°, | |
| West = 270°. | |
| Azimuth angle of the surface in degrees East of North. Surface azimuth | |
| is specified by the horizontal projection of the normal vector from | |
| the surface. Azimuth is defined as degrees East | |
| (clockwise) of North, so North = 0°, East = 90°, South = 180°, | |
| West = 270°. |
aodandclearsky_indexto glossary #2564docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Additional edit: fixed line length of some of the other definitions. Not strictly a flake8 failure but I think it looks neater and more readable.