Skip to content

perf(mobile): ship a generated Baseline Profile - #423

Closed
altaywtf wants to merge 1 commit into
mainfrom
perf/mobile-baseline-profile
Closed

altaywtf wants to merge 1 commit into
mainfrom
perf/mobile-baseline-profile

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Change

Mobile ships a generated Baseline Profile, so ART compiles its hot paths ahead of time.

Pixel 8a, nightly, Play-style speed-profile install:

Flow Without With
Compiled odex 5.7 MB 10.0 MB
Cold start (median) 171 ms 158 ms
Tab switches, slow UI frames/round 42 35
Folder open/back, slow frames/round 8.0 5.7
  • Back into a folder still drops one ~50 ms frame; that's composition, not compilation.
  • scripts/generate-baseline-profile.sh regenerates it through am instrument; Gradle's connected run passes with zero tests on API 37.

Validation

  • Code changes: ./gradlew verify and ./gradlew :mobile:assembleProductionDebug :tv:assembleProductionDebug
  • Proof for each matching row of the AGENTS.md proof map

Unverified: TV has no profile yet.

@cursor

cursor Bot commented Oct 27, 2026

Copy link
Copy Markdown

This PR is too large for Bugbot to review. It changes 37,583 lines and 3,963,464 characters. Split the change into smaller pull requests to get a review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T16:11:14.228203Z e33bdd1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf

Copy link
Copy Markdown
Member Author

Closing: the measured gain (cold start −13 ms, fewer slow tab and folder frames) doesn't justify a 37k-line generated file; Play cloud profiles cover Play installs.

@altaywtf altaywtf closed this Oct 27, 2026
@altaywtf
altaywtf deleted the perf/mobile-baseline-profile branch October 27, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant