Open
Conversation
Contributor
|
This looks great, can you write tests so we have coverage? The parsing functionality is a bit of a hotspot and I'd like to make sure we're not introducing any issues. |
Contributor
Author
|
Hi, it seems this branch does not even pass the existing tests – something I would have noticed if you had CircleCI enabled for pull requests. (Although I should have noticed it regardless.) This seems to require more work and I moved to using another date picker component in the meanwhile. So you can just close this PR unless someone else wants to pick up from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to pull request #70 implementing D and M without adding moment in the mix.