Add option to disable calendar popover#142
Open
bkuzma wants to merge 2 commits intopushtell:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table of Contents
Description
I added a prop called
calendarDisabledwhich prevents a calendar popover from being rendered when the input is focused. I added a corresponding test as well as an example to the example page.Motivation and Context
This would be useful in cases where the user is entering a date far in the past, such as a birthday, and it's more straightforward to type the date than to click back month by month for possibly dozens of years.
How Has This Been Tested?
I wrote a test which verifies that the popover isn't rendered when the
calendarDisabledprop istrue. I tested the component in Chrome 61.0.3163.100 on the examples page.Types of changes
Checklist: