fix: don't change placeholder when focused#100
Closed
mchirkin wants to merge 6 commits intopushtell:masterfrom
mchirkin:fix/placeholder-changes-onfocus-83
Closed
fix: don't change placeholder when focused#100mchirkin wants to merge 6 commits intopushtell:masterfrom mchirkin:fix/placeholder-changes-onfocus-83
mchirkin wants to merge 6 commits intopushtell:masterfrom
mchirkin:fix/placeholder-changes-onfocus-83
Conversation
Contributor
|
Some people use placeholders that are not associated with the date format, for example "Birthday." This PR would not show the date format hinting for those users, and thus removes functionality. I can't accept this as-is, would you like to instead add a |
Contributor
|
Actually, it looks like this out of date PR implements this functionality: #65 You may want to fork that work bring it up to date with this repo. |
Author
|
I added a |
Contributor
|
Hi @mchirkin - thanks for the PR! Please review the conflicts when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #83