Bump minimum deployment target to iOS 15 / macOS 12 / tvOS 15 / watchOS 9 - #70
Merged
Merged
Conversation
…OS 9 Xcode 27 enforces a hard minimum deployment target of iOS 15.0 and no longer accepts anything lower. Raises Package.swift, NWWebSocket.podspec and the Xcode project's build settings accordingly. Bumped to 1.0.0 (a real major, not a 0.x minor) specifically so pusher-websocket-swift's `.upToNextMajor(from: "0.5.9")` SPM range correctly excludes this breaking release rather than silently pulling it into apps still pinned to PusherSwift 10.x. Part of a coordinated bump across pusher-websocket-swift, tweetnacl-swiftwrap, push-notifications-swift and pusher-http-swift. Ref: pusher/engineering-manual#737 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 of 3 tasks
mykhailogrygorenko-gif
marked this pull request as ready for review
October 1, 2026 08:30
Matches the convention used in the other 4 repos' pending entries rather than a bare [Unreleased] placeholder. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pusher-websocket-swift's.upToNextMajor(from: "0.5.9")SPM range does not special-case pre-1.0 versions, so a 0.6.0 here would have silently satisfied that range and broken apps still pinned to PusherSwift 10.x on their nextswift package update. 1.0.0 correctly falls outside it.Part of a coordinated bump across
pusher-websocket-swift,tweetnacl-swiftwrap,push-notifications-swiftandpusher-http-swift.Ref: pusher/engineering-manual#737
Test plan
swift buildpasses locallypusher-websocket-swift+ this +tweetnacl-swiftwrap@2.0.0 build together as a unitswift.yml/release.ymlrun bareswift build/swift testonmacos-latest, no iOS/tvOS/watchOS simulator matrix)🤖 Generated with Claude Code