Make the --offline flag a little more offline
#1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b686611.
fsoikin
approved these changes
Jan 21, 2026
Collaborator
fsoikin
left a comment
fsoikin
left a comment
There was a problem hiding this comment.
Looks cool. I left some whenM/unlessM suggestions, but not really important, just reducing the boilerplace.
Also: what about testing this new behavior?
| pure setVersions | ||
| else do | ||
| logDebug $ "Package sets directory does not exist at " <> Path.quote Paths.packageSetsPath | ||
| pure [] |
Collaborator
There was a problem hiding this comment.
I'm not entirely sure this should return empty in this case rather than dying. What would be upstack behavior when no versions are available?
Member
Author
There was a problem hiding this comment.
this function is in a where block inside the getRegistryFns function, and the next thing that happens after it is a die in case the registry is not there. So I don't think this case ever happens, but I guess calling die is a sure way to ensure that we do the right thing 🙂
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from a note I left in here:
..so this PR does just that. We add offline-ness checking a little deeper in the stack so that we don't accidentally hit the network.