-
Notifications
You must be signed in to change notification settings - Fork 133
Remove build_plan from lockfile to improve perf #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is a breaking change, in that |
|
Code looks good, though 👍 |
fsoikin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a comment that refers to storing all transitive dependencies in the lockfile:
spago/src/Spago/Command/Fetch.purs
Lines 162 to 164 in 782311b
| -- We compute the transitive deps for all the packages in the workspace, but keep them | |
| -- split by package - we need all of them so we can stash them in the lockfile, but we | |
| -- are going to only download the ones that we need to, if e.g. there's a package selected |
I also noticed that there is a copy&paste of computing transitive deps for all workspace packages - here and here. Perhaps these should be consolidated?
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
Fix #1262 by following the approach I explained at the time - we remove
build_planfrom each package of the lockfile since it's faster to recompute it than to decode it, as the files can get massive.cc @finnhodgkin