Return true on trusted_path if path is really trusted.#79
Open
Le-onardo wants to merge 1 commit intopuppetlabs:mainfrom
Open
Return true on trusted_path if path is really trusted.#79Le-onardo wants to merge 1 commit intopuppetlabs:mainfrom
Le-onardo wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
|
|
joshcooper
reviewed
Apr 12, 2024
| path = path.dirname | ||
| end | ||
| Puppet.debug('Path trusted, writing the file as the current user') | ||
| return true |
Contributor
There was a problem hiding this comment.
Thanks! There should be a test to verify this behavior. Do you know if one exists already?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If drop_privileges is set to false (default is true), the trusted_path function does check if the path is trusted or not and returns false if this isn't the case. If this conditional path is not hit, there is no return true, which leaves the state of the function 'nil', thus being false.
This change should account for the true case.