fix: better spacing for RewriteRule#2589
Open
teluq-pbrideau wants to merge 2 commits intopuppetlabs:mainfrom
Open
fix: better spacing for RewriteRule#2589teluq-pbrideau wants to merge 2 commits intopuppetlabs:mainfrom
teluq-pbrideau wants to merge 2 commits intopuppetlabs:mainfrom
Conversation
teluq-pbrideau
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
|
|
smortex
approved these changes
Feb 26, 2025
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
+1 for generating better VHost even if this is somewhat a breaking change.
Testing the whole generated fragments as a single test instead of each line as currently done in this module and a lot of other puppet modules would not only run faster, but make it obvious that the generated config is changed. It would also help spotting this kind of issues when they are introduced, or spot unexpected changes when reworking templates.
teluq-pbrideau
force-pushed
the
fix/rewriterule_spacing
branch
from
b0d0346 to
8a3ca22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix spacing for RewriteRule
Additional Context
Related Issues (if any)
#2588
Checklist
puppet apply)