chore(release): v0.21.1 — fix --set-release artifact corruption#601
Merged
Conversation
Patch for the data-corruption bug in v0.21.0's --set-release: inserting a new base field before a trailing provenance: block produced invalid YAML, dropping the artifact on reload. See CHANGELOG.md [0.21.1].
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d81b0b9 | Previous: f489a91 | Ratio |
|---|---|---|---|
store_lookup/10000 |
459924 ns/iter (± 10905) |
366585 ns/iter (± 1098) |
1.25 |
traceability_matrix/1000 |
59407 ns/iter (± 682) |
45641 ns/iter (± 205) |
1.30 |
query/10000 |
329282 ns/iter (± 3598) |
238638 ns/iter (± 1752) |
1.38 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release. Fixes a data-corruption P0 in v0.21.0.
The fix (#600, already on main)
rivet modify --set-releaseinserted the newrelease:key inside a trailingprovenance:block, producing invalid YAML → the artifact vanished on reload. Every AI-stamped artifact has aprovenance:block, so the command corrupted most artifacts it touched. The inserter now skips a field's full extent (including nested block-mapping children).Found by dogfooding the v0.21.0 release field while planning v0.22 — a real
--set-releaseon rivet's ownrequirements.yamlcorrupted it.Version bumps
Cargo.toml/Cargo.lock→ 0.21.1vscode-rivet/package.json→ 0.21.1CHANGELOG.md[0.21.1]Regression test
set_field_inserts_after_trailing_provenance_blockguards it.docs checkPASS.🤖 Generated with Claude Code