Fix some bugs that cause minor annoyances… - #22
Open
savetheclocktower wants to merge 4 commits into
Open
Conversation
…during the build process. Claude ferreted these out; the precipitating annoyance was the fact that `yarn install` in the Pulsar repo often somehow forces me to re-run the download-`libiconv` step. Claude doesn't know why the existing version gets removed during that process, but says that `yarn build` doesn't catch the omission because the are-we-still-fresh metadata doesn't know to check for `libiconv.2.dylib`. Also, Claude spotted some bugs in the `fetch-libiconv-61.sh` script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…during the build process.
Claude ferreted these out; the precipitating annoyance was the fact that
yarn installin the Pulsar repo often somehow forces me to re-run the download-libiconvstep. Claude doesn't know why the existing version gets removed during that process, but says thatyarn builddoesn't catch the omission because the are-we-still-fresh metadata doesn't know to check forlibiconv.2.dylib. The fix is to move that file into the same directory assuperstring.node.Also, Claude spotted some bugs in the
fetch-libiconv-61.shscript.The proof here will be in the CI; if this works just as well in CI, then I'll consider it to be a lateral move at worst. These bugs would hardly ever surface during Pulsar builds because we're always starting from scratch, but fixing them may mean I have slightly fewer headaches.