Add repository support to deb distributions - #257
Closed
mehuljariwala wants to merge 1 commit into
Closed
Conversation
mdellweg
requested changes
Aug 31, 2026
mdellweg
left a comment
Member
There was a problem hiding this comment.
Read the documentation first.
(Good first time issues are meant for actual human contributors btw.)
Author
|
You are right that I missed the organization-level AI policy requirement: the AI-assistance disclosure needed to be in the commit message, not only in the PR description. This contribution was AI-assisted, and this automated workflow cannot itself provide the human review and personal responsibility your policy requires. I will close the PR and step back from the issue rather than imply compliance. Apologies for not finding the organization-wide policy before submitting. |
Author
|
Closing to respect the Pulp AI contribution policy and the maintainer’s request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
repositoryoption topulp.squeezer.deb_distribution, allowing an APT distribution to track and serve the latest version of a named DEB repository.Fixes #250.
Implementation
PulpAptRepositoryContextand sends the resulting Pulp href to the distribution API.repositoryandpublicationmutually exclusive, matching Pulp's API and the existingrpm_distributionmodule behavior.Validation
pytest -v tests/test_deb_distribution.py— 2 tests passed.make test_deb_distribution— replay and check-mode tests passed.make lint— passed, including playbook syntax, Black, isort, Galaxy importer, and ansible-lint.make sanity— full Ansible sanity suite passed on Python 3.13.git diff --check— passed.The Galaxy importer emitted the repository's existing warning that the collection has no changelog file; import completed successfully.
Compatibility and risk
The option is additive. Existing publication-backed distributions are unchanged. The implementation mirrors the established RPM distribution path and uses the
pulp-glue-debrepository context already used elsewhere in this collection.AI assistance
OpenAI Codex assisted with repository analysis, implementation, and test orchestration. The changes were reviewed against the existing RPM implementation and current Pulp DEB documentation, and were validated with the commands above.