Skip to content

Fix RepositoryVersion.remove_content using wrong queryset for lazy co… #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
git-hyagi wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix RepositoryVersion.remove_content using wrong queryset for lazy co… #7853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/7851.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed `RepositoryVersion.remove_content` incorrectly removing all content instead of only the specified lazy content.

@gerrod3 gerrod3 Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really reflect the scenario the remove could fail in. It's when the remove is self-referential and the amount is greater than 65k, correct?

4 changes: 2 additions & 2 deletions pulpcore/app/models/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,13 +1231,13 @@ def remove_content(self, content):
# Undo addition by deleting the RepositoryContent.
RepositoryContent.objects.filter(
repository=self.repository,
content_id__in=content,
content_id__in=to_remove,

@gerrod3 gerrod3 Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when to_remove is greater than 65k? Does this break?

version_added=self,
version_removed=None,
).delete()

q_set = RepositoryContent.objects.filter(
repository=self.repository, content_id__in=content, version_removed=None
repository=self.repository, content_id__in=to_remove, version_removed=None
)
q_set.update(version_removed=self)

Expand Down
Loading