Open
Conversation
extract_pk() was ~1000x slower for HREFs than PRNs (22.5s vs 0.024s for 10k items) because it called Django's URL resolver on every invocation. Replace it with a direct UUID extraction from the path, which matches the function's documented intent of not validating resource existence. Add unit tests for extract_pk covering valid HREFs, PRNs, and various invalid inputs including nested URLs (e.g. RepositoryVersion). Closes pulp#6237 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pedro-psb
force-pushed
the
fix-slow-extract-pk
branch
from
fd97cab to
2b3b09c
Compare
dralley
reviewed
Mar 24, 2026
|
|
||
| EXTRACT_PK_CASES = [ | ||
| # happy cases | ||
| pytest.param( |
Contributor
There was a problem hiding this comment.
You need a test for repository versions - this is where it gets tricky, because you can have nesting.
Contributor
There was a problem hiding this comment.
Well, I guess not, because extract_pk is documented to not support nested URLs.
Member
Author
There was a problem hiding this comment.
The last case asserts it can't handle nested pks, which is documented in the docstring, as you said.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_pk() was ~1000x slower for HREFs than PRNs (22.5s vs 0.024s for 10k items) because it called Django's URL resolver on every invocation. Replace it with a direct UUID extraction from the path, which matches the function's documented intent of not validating resource existence.
Add unit tests for extract_pk covering valid HREFs, PRNs, and various invalid inputs including nested URLs (e.g. RepositoryVersion).
Closes #6237
📜 Checklist
See: Pull Request Walkthrough