Enable DELETE on the Docker v2 blob endpoint#2380
Open
gerrod3 wants to merge 1 commit into
Open
Conversation
gerrod3
added a commit
to gerrod3/pulp_container
that referenced
this pull request
Jun 1, 2026
Fixes lint failure blocking CI on PR pulp#2380. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
gerrod3
added a commit
to gerrod3/pulp_container
that referenced
this pull request
Jul 1, 2026
Fixes lint failure blocking CI on PR pulp#2380. Co-authored-by: Cursor <cursoragent@cursor.com>
05264ca to
a9b8ff9
Compare
gerrod3
added a commit
to gerrod3/pulp_container
that referenced
this pull request
Jul 7, 2026
Fixes lint failure blocking CI on PR pulp#2380. Co-authored-by: Cursor <cursoragent@cursor.com>
fa0add0 to
e2155f0
Compare
mdellweg
reviewed
Jul 8, 2026
|
|
||
| return repository, blob.digest | ||
|
|
||
| def test_01_delete_invalid_digest(self, setup, local_registry, full_path): |
Contributor
Author
There was a problem hiding this comment.
Run the tests in a specific order. The fail cases and then the success case.
Comment on lines
+1240
to
+1241
| if not blob: | ||
| pending_blob = repository.pending_blobs.filter(digest=pk).first() |
Member
There was a problem hiding this comment.
I think I would prefer a single return statement.
Basically
if blob := ... :
...
elif blob := ... :
...
else:
raise NotFound()
return Response(202) # Accepted
Member
There was a problem hiding this comment.
It's not a blocking requirement...
Implement DELETE /v2/<name>/blobs/<digest> for push repositories, with functional tests. Fixes pulp#481. Co-authored-by: Cursor <cursoragent@cursor.com>
e2155f0 to
441e008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /v2/<name>/blobs/<digest>to the registry API for push repositoriesrecursive_remove_contentTest plan
pytest pulp_container/tests/functional/api/test_delete_blob.py -vFixes #481
Made with Cursor