Skip to content

Add shared base types for Repositories, Publications, Remotes and Distributions - #307

Merged
ggainey merged 10 commits into
pulp:mainfrom
Redtigercod4:feat/255-base-resource-types
Sep 1, 2026
Merged

Add shared base types for Repositories, Publications, Remotes and Distributions#307
ggainey merged 10 commits into
pulp:mainfrom
Redtigercod4:feat/255-base-resource-types

Conversation

@Redtigercod4

@Redtigercod4 Redtigercod4 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Added shared base types in new src/api/common.ts, mapped against Pulp's core
serializer types (repository, remote, distribution, publication). Types only —
no behavioural or structural changes to existing API calls.

Changes

  1. Added src/api/common.ts with GenericResource, GenericRepository,
    GenericRemote, GenericDistribution, GenericPublication and shared
    plugin types.
  2. Updated interfaces in related Ansible plugins to extend the new Generic
    types, correcting several field type mismatches.
  3. Added types to RPM plugins, previously untyped.
  4. Added types to File plugins, previously untyped.
  5. Added Container Distribution types, previously untyped.

Related

  1. Issue - Base / Common class properties/types #255
  2. Pull Request - Rough draft rpm repository management #254

Sources

  1. https://github.com/pulp/pulp_container/tree/main
  2. https://github.com/pulp/pulp_ansible/tree/main
  3. https://github.com/pulp/pulpcore/tree/main
  4. https://github.com/pulp/pulp_rpm

@Redtigercod4
Redtigercod4 force-pushed the feat/255-base-resource-types branch from 81288d7 to 8ccab40 Compare July 2, 2026 20:02
@Redtigercod4 Redtigercod4 changed the title Add shared base types for File, Ansible, and RPM repository types. Add shared base types for Repositories, Publications, Remotes and Distributions. Jul 2, 2026
@Redtigercod4 Redtigercod4 changed the title Add shared base types for Repositories, Publications, Remotes and Distributions. Add shared base types for Repositories, Publications, Remotes and Distributions Jul 2, 2026
@Redtigercod4
Redtigercod4 marked this pull request as ready for review July 2, 2026 20:20
@Redtigercod4

Copy link
Copy Markdown
Contributor Author

@himdel Good advice on the previous PR, this one is smaller and more focused on base types against Pulp Core. I have now built out a fully typed & tested RPM Repository Client on the API layer but is now blocked by this one. There is an issue tracking all this work under #309

Would it be possible to get a review on this one so that I can fully raise the others?

Blocked PRs:

@ggainey

ggainey commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Closing and reopening to get CI re-run after all the dependdency-updates

@ggainey ggainey closed this Sep 1, 2026
@ggainey ggainey reopened this Sep 1, 2026
@ggainey
ggainey merged commit 63dcded into pulp:main Sep 1, 2026
4 checks passed
@Redtigercod4
Redtigercod4 deleted the feat/255-base-resource-types branch September 1, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants