[ptr727]

Summary

This answers the review findings on the promotion pull request #3521:

• spec/validate.py rejects a tier model value that is not a non-empty string. The deployed guard's load_tiers() reads such a value as an unreadable mapping and then refuses every named model.
• The guard's docstring names both edits a model release makes, the hub's spec/model-tiers.json and its AGENTS.md tier table, rather than the mapping alone.
• The tier tests hold the models mapping as a typed fixture of their own, which drops an unexplained # type: ignore[index]. A new test covers a null, numeric, and empty model value.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 07edec5d1b9afc3c82f963ddc7950c0f46ed0512, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: promotion-3521-review-fixes
• File: .coderabbit.yaml
• Commit: 07edec5
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5cd7a7a0-3f46-42db-aaf0-095a87236a42

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

The change is a narrow validator tightening with a matching test, and the docstring now matches the sync check that model_tier_errors already enforces.

No open issues 🎉

What changed in this PR

This change answers review findings on promotion pull request #3521. It makes the hub's model tier validator reject any tier model value that is not a non-empty string. The guard's docstring now names both edits a model release needs, the tier config and the AGENTS.md tier table. The tier tests also get a typed models fixture and a new test for bad model values.

Changes:

• spec/validate.py adds a check that every tier model is a non-empty string. A null, number, or empty value now produces a clear error instead of reaching the deployed guard.
• tests/test_spec_validate.py moves the models mapping into a typed fixture, which removes the # type: ignore[index]. A new subtest covers null, 7, and "".
• host-setup/agent-safety/claude/model-tier-guard.py updates the module docstring so a model release is described as an edit to both the hub's spec/model-tiers.json and its AGENTS.md tier table.

File	Description
tests/​test_spec_validate.py	Adds a typed models fixture and a subtest that rejects a null, numeric, or empty tier model.
spec/​validate.py	Rejects any tier model that is not a non-empty string, placed after the existing tier-set check on the same error path.
host-setup/​agent-safety/​claude/​model-tier-guard.py	Docstring now names both the tier config and the AGENTS.md table as the places a model release edits.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.54%. Comparing base (487ed74) to head (07edec5).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3522   +/-   ##
========================================
  Coverage    81.53%   81.54%           
========================================
  Files           26       26           
  Lines         8964     8967    +3     
========================================
+ Hits          7309     7312    +3     
  Misses        1655     1655           

Flag	Coverage Δ
python-3.13	81.54% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.