Promote the pr_review.py Shared Helpers to Main by ptr727 · Pull Request #3499 · ptr727/ProjectTemplate

ptr727 · 2026-10-26T03:30:04Z

Summary

Promotes the pull requests merged into develop since release 2.0.1192.

#3498: scripts/pr_review.py's repeated refusal, subprocess, write-confirmation, and ref-check shapes each get one primitive, not_written and scope_refusal, _run, mutated and unconfirmed, and safe_ref, and every site moves onto them, pr_cleanup.branch_rules included. Every printed line and exit code is unchanged, which a before-and-after recording of each touched function over the pr_review and pr_cleanup suites shows, along with a probe of each subprocess wrapper's start-failure paths.
#3500: dependabot's actions-deps group bumps docker/login-action from 4.6.0 to 4.7.0, plus astral-sh/setup-uv and actions/setup-python, across the workflows and composite actions that pin them.

Constituent coverage

Each change this promotion carries had coverage on its own pull request into develop:

Pull request	Merged head	Coverage
#3498	`7e63bc09`	attested local pass at the merged head, base `develop`, and a Copilot table on the merged head naming exactly its 2 changed files, no open findings
#3500	`79f11c72`	merged by the `ptr727-codegen` app, with no local pass or Copilot round on its own pull request, so this promotion's own Copilot round covers it

🤖 Generated with Claude Code

…ef Checks Into Helpers (#3498) ## Summary Each of the four shapes #3459 names in `scripts/pr_review.py` now has one primitive, and every site uses it: - **Refusals.** `not_written(status, why, code, *details)` prints a refusal that wrote nothing, with any detail lines after it. `scope_refusal(owner)` is the out-of-scope refusal that `comment_on_pr`, `attest`, `reply_to_thread`, and `run_wait` each wrote out. - **Subprocess calls.** `_run(argv, timeout, unrun, **options)` captures one command and returns a failure to start or finish as exit 1. `_git`, `_gh_run`, `head_carries`, `receipt_reading`, and `origin_owner` call it. `_git`, `_gh_run`, and `head_carries` stay as thin wrappers, since tests patch them. `origin_owner` keeps its broad `except` for a decode error. - **Write confirmation.** `mutated(data, *path)` walks a mutation's response. `unconfirmed(status, why, response, code)` reports a response that did not confirm the write. They are used in `comment_on_pr`, both steps of `answer_thread`, and `request_copilot_review`'s response walk. - **Ref checks.** `safe_ref(ref)` is the REST-path ref check, used by `required_contexts`, `attest`, `await_registered_head`, and `pr_cleanup.branch_rules`. ## Verification Every printed line and exit code is unchanged: - I wrapped each touched function, plus `main` and `pr_cleanup.branch_rules`, and recorded its return value and stdout keyed by test id. I ran the full `test_pr_review` and `test_pr_cleanup` suites before and after the change, 1132 records each. After normalizing commit SHAs and temp paths, the records match. The one difference is a frozenset's repr order, which comes from string hash randomization. - The suite never makes `_git`, `_gh_run`, `receipt_reading`, or `origin_owner` fail to start. So I stubbed `subprocess.run` to raise `FileNotFoundError`, `TimeoutExpired`, and `UnicodeDecodeError`, and ran each of those four plus `head_carries` against both versions. All 15 results are identical. - The full suite (`python -m unittest discover -s tests`) passes: 2965 tests, 7 skipped. ruff and mypy are clean. Two local strict-review passes ran at the `frontier` tier. The first found one missed mutation walk and one stale comment, and 7e63bc0 fixes both. The second found nothing in this change. This PR carries the `comments` label for the one comment line it rewrites, in `origin_owner`. ## Dropped findings - `scripts/pr_review.py`, `answer_thread`: the REPLY_NOT_CONFIRMED text says "Read the response above", but the response prints below it. This is wording on text this change did not touch, and this change keeps the string byte-identical by contract (`style`). Refs #3459 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-26T03:30:11Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: ptr727/ProjectTemplate
Branch: develop
File: .coderabbit.yaml
Commit: 8321f0e
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: e5938d15-6695-4332-80e8-ac23bb9bf82a

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

🟢 Approval recommended

No unresolved review findings were identified, and all reviewed files are covered by the completed refactor.

No open issues 🎉

What changed in this PR

Promotes shared helper refactoring from develop to main across the pull-request review and cleanup tooling while preserving existing output and exit-code behavior.

Changes:

Centralizes mutation, refusal, subprocess, write-confirmation, and safe-reference helpers.
Migrates affected pr_review.py workflows to the shared helpers.
Reuses pr_review.safe_ref for branch validation in pr_cleanup.py.

File	Summary
`scripts/pr_review.py`	Adds and applies shared helpers across review, attestation, reply, wait, mutation, subprocess, and reference-validation paths.
`scripts/pr_cleanup.py`	Uses `pr_review.safe_ref` for branch-rule validation.

_{Review effort: Lite}

codecov · 2026-10-26T03:35:05Z

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (162d1aa) to head (8321f0e).
⚠️ Report is 426 commits behind head on main.

Files with missing lines	Patch %	Lines
scripts/pr_review.py	96.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
+ Coverage   81.07%   81.10%   +0.03%     
==========================================
  Files          26       26              
  Lines        8928     8907      -21     
==========================================
- Hits         7238     7224      -14     
+ Misses       1690     1683       -7

Flag	Coverage Δ
python-3.13	`81.10% <96.66%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

🟢 Approval recommended

All reviewed files have no unresolved findings, and the changes preserve the documented behavior.

No open issues 🎉

_{Review effort: Lite}

Copilot AI lite review requested due to automatic review settings October 26, 2026 03:30

Copilot started reviewing on behalf of ptr727 October 26, 2026 03:30

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

ptr727 mentioned this pull request Oct 26, 2026

Session Handoff [default]: Copilot Unresolved Findings Label Ready in Promotion #3515, Merge and Release Next #2361

Open

ptr727 requested a lite review from Copilot October 26, 2026 14:56

Copilot started reviewing on behalf of ptr727 October 26, 2026 14:56

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

ptr727 merged commit 5344d82 into main Oct 26, 2026
14 checks passed

Navigation Menu

Repository navigation

Promote the pr_review.py Shared Helpers to Main - #3499

Promote the pr_review.py Shared Helpers to Main#3499
ptr727 merged 2 commits into
mainfrom
develop

ptr727 commented Oct 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Constituent coverage

Uh oh!

coderabbitai Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

codecov Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptr727 commented Oct 26, 2026 •

edited

Loading

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

codecov Bot commented Oct 26, 2026 •

edited

Loading