Skip to content

Say the Env File Is Sourced and Named, Not That ENV_FILE Is Sourced - #564

Merged
ptr727 merged 1 commit into
developfrom
feature/env-file-named-and-sourced
Oct 28, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/env-file-named-and-sourced

Conversation

@ptr727

@ptr727 ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the headline of Copilot's second round on promotion #562, which read OPERATIONS.md as saying ENV_FILE is sourced. The sentence "ENV_FILE is set as well as sourced" meant that the shell sources the file and the command also names it in ENV_FILE. Read literally, it says the variable is sourced, so it now says "The file is both sourced in the shell and named in ENV_FILE".

Verification

  • Hub prose gate: clean without the comments label. The opt-in sentence-length check flags only the older 38-word "The script reads its own file regardless" sentence on the same line.
  • Local strict review: one pass, recorded against develop, raised none. It also swept OPERATIONS.md, ENVIRONMENT.md, deploy/README.md, README.md, and .secrets/README.md. No other sentence says ENV_FILE or the script sources the file.

Dropped findings

  • OPERATIONS.md:70: opt-in sentence-length flags the 38-word "The script reads its own file regardless" sentence. This change does not write it. Class: style.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 28, 2026 21:40
@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 3a5550a86db10e8b5f0ce5f879fbdfbdd34a39b3, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ab0bf0d1-0ce6-4814-b8c2-d76100c5c57e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review found no active issues, and the documentation change clearly distinguishes shell sourcing from the release script’s ENV_FILE usage.

No open issues 🎉

What changed in this PR

Clarifies that the environment file is sourced in the shell, while ENV_FILE names the file used by the release script.

Changes:

  • Rephrases the ambiguous ENV_FILE explanation in OPERATIONS.md.
  • Preserves the rationale for using both shell sourcing and ENV_FILE.
File Description
OPERATIONS.md Clarifies the relationship between shell sourcing and the ENV_FILE variable.

Review effort: Lite

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.98%. Comparing base (7063a41) to head (3a5550a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #564   +/-   ##
========================================
  Coverage    53.98%   53.98%           
========================================
  Files           12       12           
  Lines         3412     3412           
========================================
  Hits          1842     1842           
  Misses        1570     1570           
Flag Coverage Δ
python-3.13 53.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ptr727
ptr727 merged commit b09f9e4 into develop Oct 28, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/env-file-named-and-sourced branch October 28, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants