Small fixes to build Envoy#473
Closed
jwendell wants to merge 2 commits intoproxy-wasm:mainfrom
Closed
Conversation
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
leonm1
approved these changes
Dec 15, 2025
mpwarres
approved these changes
Dec 15, 2025
Author
|
ping |
Contributor
|
Does this still need merged? I'm under the impression github.com/envoyproxy/envoy/pull/42718 fixed the build issue on the Envoy side. |
Author
|
@leonm1 thanks, it seems we fixed this on our side with another approach - curiously that was my first attempt but one maintainer recommended the approach in this pr. Anyway, let's close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.