Fix uint16_t capacity truncation bug in ExtensionSet::GrowCapacity - #28987
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_958067520
branch
from
August 3, 2026 22:56
18c0d87 to
1111ec2
Compare
In ExtensionSet::GrowCapacity, auto new_flat_capacity was deduced as uint16_t from flat_capacity_. When merging a large extension set (>2**16 elements), quadrupling new_flat_capacity (16384 * 4 = 65536) wrapped back to 0 in uint16_t, causing an infinite loop. This change explicitly sets new_flat_capacity type to size_t to prevent truncation. A unit test MergeLargeExtensionSetToEmpty is added to extension_set_unittest.cc to cover this case. PiperOrigin-RevId: 958634496
copybara-service
Bot
force-pushed
the
test_958067520
branch
from
August 3, 2026 23:21
1111ec2 to
42e27e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix uint16_t capacity truncation bug in ExtensionSet::GrowCapacity
In ExtensionSet::GrowCapacity, auto new_flat_capacity was deduced as uint16_t from flat_capacity_. When merging a large extension set (>2**16 elements), quadrupling new_flat_capacity (16384 * 4 = 65536) wrapped back to 0 in uint16_t, causing an infinite loop.
This change explicitly sets new_flat_capacity type to size_t to prevent truncation. A unit test MergeLargeExtensionSetToEmpty is added to extension_set_unittest.cc to cover this case.