Fix sign compare warnings#26131
Open
pps83 wants to merge 3 commits intoprotocolbuffers:mainfrom
Open
Conversation
`generated_message_tctable_impl.h` gets included in user code and results in huge warning output as following: ``` 2>In file included from ..\source\CppClient\client\protobuf/AccountDataEnd.pb.h:21: 2>In file included from C:\work-pps\twsapi-git\ext\protobuf\src\google/protobuf/io/coded_stream.h:111: 2>In file included from C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/absl_check.h:38: 2>In file included from C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/internal/check_impl.h:21: 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/internal/check_op.h(503,43): warning : comparison of integers of different signs: 'const unsigned int' and 'const int' [-Wsign-compare] 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/internal/check_op.h(492,33): message : expanded from macro 'ABSL_LOG_INTERNAL_CHECK_OP_IMPL' 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/base/optimization.h(190,58): message : expanded from macro 'ABSL_PREDICT_TRUE' 2>C:\work-pps\twsapi-git\ext\protobuf\src\google/protobuf/generated_message_tctable_impl.h(895,7): message : in instantiation of function template specialization 'absl::log_internal::Check_NEImpl<unsigned int, int>' requested here 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/absl_check.h(76,3): message : expanded from macro 'ABSL_DCHECK_NE' 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/internal/check_impl.h(76,3): message : expanded from macro 'ABSL_LOG_INTERNAL_DCHECK_NE_IMPL' 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/internal/check_impl.h(51,3): message : expanded from macro 'ABSL_LOG_INTERNAL_CHECK_NE_IMPL' 2>C:\work-pps\twsapi-git\ext\abseil-cpp\absl/log/internal/check_op.h(69,51): message : expanded from macro 'ABSL_LOG_INTERNAL_CHECK_OP' ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generated_message_tctable_impl.hgets included in user code and results in huge warning output as following: