Repository navigation
Clarify that an unproven-hop lead is excluded from totals; split eval expectation - #2302
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
… expectation Whole-app security mode step 5 now states that a lead for an unproven hop is not a finding and does not count toward severity totals, citing appsec-verify.md. Eval env-gated-dev-bypass-not-reported splits its unverified expectation into two atomic lines. Tests: 165/168 in scripts/test-ci-gates.sh locally; the 3 failures are environment-only (byte-budget size check, since derived size rows are regenerated by CI; dcr-gates opt-in all three gates off by default and refix_gate Refix-Reason trailer, which hit sandbox serial_gate lock limits). mustload ok, test_appsec_split 7/7. size-budget-raise: .claude/skills/deep-code-review/references/security-review-mode.md 14821→14908 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #2304. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5 of whole-app security mode now says a lead for an unproven hop is not a finding and does not count toward severity totals, citing appsec-verify.md. Eval env-gated-dev-bypass-not-reported splits its unverified expectation into two atomic lines. Replaces #2299.
Local gates: mustload ok, test_appsec_split 7/7, test-ci-gates 165/168. The 3 environment-only red gates are: (1) size: the real repo's SKILL.md/references files are all within their frozen byte budget (CI regenerates derived size rows; review-config.md is already over budget on main); (2) dcr-gates opt-in: all three gates are off by default; (3) dcr-gates opt-in: refix_gate passes with a Refix-Reason trailer. Gates 2 and 3 hit sandbox serial_gate lock limits.
🤖 Generated with Claude Code