Repository navigation
Route govulncheck for Go repos and add opt-in Scorecard rows to the settings audit - #2290
Merged
Merged
Conversation
…-scorecard row per repo govulncheck joins the tool hub. When the root go.mod changes it runs `govulncheck -format json ./...` (GOPROXY=off GOTOOLCHAIN=local) and keeps only vulnerabilities the code actually calls, one row each on go.mod with the call site and fixed version in the message. Imported-only findings are dropped, which is the noise cut over dependency scanners. A missing govulncheck or Go toolchain is NOT CHECKED; output with no config message, a stray line in the JSON stream, or a crash is "not run", never clean. repo_settings_audit.py gains --scorecard: a public repo gets an info row with the OpenSSF Scorecard aggregate score (kept in --json rows); a private repo, a missing scorecard binary or a failed run is an explicit not-checked row. It calls scorecard directly with --format=json because supply_chain_check.sh --scorecard prints text only. The measured before/after noise delta on a real Go repo from the issue's done-when is not included: it needs the vulnerability database over the network. size-budget-raise: .claude/skills/deep-code-review/references/tool-hub.md 15770→16597 govulncheck registry row and the repo_settings_audit --scorecard flag Tests: 72/72 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
run_scorecard now treats a score that is NaN, infinite or outside 0..10 as a failed run, so the row is not-checked instead of a bogus aggregate score. Tests: 9/9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Row 16646 to 17473 bytes with a size-budget-raise marker in the fragment. Tests: 23/23 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review_checks.shnow routes govulncheck for Go repositories (repos with ago.mod). Findings come out as review rows. If govulncheck is missing, or the run fails, the result is reported as NOT CHECKED. It never counts as a silent pass.repo_settings_audit.pygains an opt-in--scorecardflag. It adds one OpenSSF Scorecard row per repository. A score that is non-finite or outside the 0–10 range is rejected and reported as not checked.tool-hub.mdroute rows anddocs/standards-index.mdare updated for both tools.Closes #2285
Closes #2284
Tests
scripts/test-review-checks-govulncheck.sh: 9/9scripts/test_repo_settings_scorecard.pyand the existing settings audit tests: 55/55tool-hub.mdgrows from 16646 to 17473 bytes; the raise is recorded in thechangelog.dfragment.🤖 Generated with Claude Code