Repository navigation
review_checks: report semgrep as not checked when it scans zero files - #2289
Merged
Merged
Conversation
When semgrep reports an empty paths.scanned list and no findings, the hub now records a not-checked row and prints "NOT CHECKED: semgrep scanned 0 files" instead of treating the chunk as clean. Adds a regression test. Tests: 4/4 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4dfwe8bGsWUqekBt1dkaf
A semgrep chunk with errors, empty paths.scanned and no results was forced to rc=5 (zero files), losing the errored not-checked row. Guard that branch with not err. Tests: 3/3 semgrep scripts pass Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2283.
review_checks.shtreated a semgrep chunk that scanned 0 files as clean. It now reports semgrep as NOT CHECKED: one line and one not-checked row when every chunk scanned 0 files, and no false not-checked row when only some chunks did. A chunk whose files all errored stays reported as errored, even when semgrep lists no scanned files.Tests: 6/6 (
scripts/test-review-checks-semgrep-zero-files.sh, wired into the CI test set).🤖 Generated with Claude Code