Support rebar binary in system#44
Conversation
This provides the binary of rebar. However, I think that using the rebar binary installed in the system in many cases. When rebar is already installed in system, this change that rebar of System use installed. When not provided, use the binary provide in source. Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
There was a problem hiding this comment.
I would change this to
+REBAR_BIN ?= $(shell which rebar || echo ./rebar)And three lines below are not necessary anymore. Moreover, we can specify the rebar binary with the environment variable.
|
Thanks you for your comment. |
|
I know it has been long since this was submitted, but can I please ask for some more "motivation" why this pull request is worthwhile to include? For example, have you experienced any errors with the rebar included in PropEr? Note that PropEr does not just include a copy of rebar in its code base but instead includes a patched rebar, which e.g. shuts off some warnings when running eunit. Why is it preferable to use a rebar that does not do what exactly PropEr wants it to do? |
|
@kostis, if I have proper as a dependency in another rebar project I would prefer to be able to ensure I have a consistent version of rebar throughout my build tool. So I'd prefer if the eunit issue can be addressed by the rebar project upstream, and then @motiejus fix could go in. Shipping rebar in every project is like including make or autotools - it doesn't make sense to me. |
This set of changes allows PropEr to be built using rebar3 instead of its own (patched) rebar version. Besides being more modern, this allows for easier integration of PropEr in code bases that use it as a dependency. Note that PropEr's version of rebar is still used for running the unit tests, mainly due to being able to shut off more warnings than when using rebar3. However, this only affects PropEr developers, not users. Addresses #204 and a request by propcheck. Obsoletes #44 and most of #168.
|
After a bit less than 7 years, I finally created a pull request (#211) that does the above for building PropEr but using Thanks for your contribution! As they say, "Good things come to those who wait." :-) |
|
#211 is now merged into master, to I am closing this. |
4 participants
This provides the binary of rebar. However, I think that using the rebar binary
installed in the system in many cases.
When rebar is already installed in system, this change that rebar of System use
installed. When not provided, use the binary provide in source.
Signed-off-by: Nobuhiro Iwamatsu iwamatsu@nigauri.org