Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 21, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completion.__hash__hashesself.display, but the constructor always normalizes that field toFormattedText, a list subclass. Consequently evenhash(Completion("example"))raisesTypeError, preventing completion objects from being used as dictionary keys or in sets.Hash the completion text and start position instead. Equal completions already share those fields, so the equality/hash contract is maintained without requiring display or metadata to be hashable and without evaluating lazy metadata. Unequal completions with matching text/position may share a hash, which is permitted and is resolved by the existing equality implementation.
Tests cover default displays and dictionary/set use, formatted display plus formatted metadata, and lazy metadata that must not be evaluated.
Validation
uv run prek run --all-files.ruff check,ruff format --check,typos, and strict mypy for win32/linux/darwin passed.uv build --no-sources.AI assistance was used to investigate, implement, and test this change. No human review or remote CI success is claimed.