Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 15, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menu's Enter handler invokes actions even when their MenuItem has disabled=True. Opening a submenu selects its first child, so Down followed by Enter can run a disabled action; the existing submenu mouse handler already rejects it.
Check the current disabled flag before invoking the handler or changing focus. Menu navigation remains unchanged. Seven new cases cover enabled/disabled actions at three depths and disabling/re-enabling an already selected item.
Validation on Linux / CPython 3.12.14:
The mypy platform targets are static checks; other interpreter/native OS matrix combinations were not run locally.
Prepared and tested with OpenAI Codex assistance. No human review is claimed.