Patch React 15 warnings#155
Open
ifunk wants to merge 3 commits intoprometheusresearch-archive:developfrom
adamroyle:patch-react15-warnings
Open
Patch React 15 warnings#155ifunk wants to merge 3 commits intoprometheusresearch-archive:developfrom adamroyle:patch-react15-warnings
ifunk wants to merge 3 commits intoprometheusresearch-archive:developfrom
adamroyle:patch-react15-warnings
Conversation
Contributor
Author
|
I should note preventing spreading of props might be a breaking change for people who are passing through a component for Fieldset instead of a dom string, but they should be able to refactor their code to use Fieldset directly inside their component instead. |
|
any chance this gets merged? |
|
Would appreciate if you could merge it |
|
Pretty please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this warning (#150) when value for input is
undefinedornullby using an empty string for value when required.Fixes this warning by removing known keys from spreaded props.