Skip to content

timex: filter unreasonable offset values from kernel adjtimex() overflow #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dongjiang1989 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

timex: filter unreasonable offset values from kernel adjtimex() overflow #3766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion collector/timex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,15 @@ func (c *timexCollector) Update(ch chan<- prometheus.Metric) error {
divisor = microSeconds
}

offsetSec := float64(timex.Offset) / divisor
if offsetSec > 1.0 || offsetSec < -1.0 {
c.logger.Warn("Discarding unreasonable timex offset value",
"offset_seconds", offsetSec, "status", status)
offsetSec = 0
}

ch <- c.syncStatus.mustNewConstMetric(syncStatus)
ch <- c.offset.mustNewConstMetric(float64(timex.Offset) / divisor)
ch <- c.offset.mustNewConstMetric(offsetSec)
ch <- c.freq.mustNewConstMetric(1 + float64(timex.Freq)/ppm16frac)
ch <- c.maxerror.mustNewConstMetric(float64(timex.Maxerror) / microSeconds)
ch <- c.esterror.mustNewConstMetric(float64(timex.Esterror) / microSeconds)
Expand Down
4 changes: 4 additions & 0 deletions docs/node-mixin/alerts/alerts.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,16 @@
expr: |||
(
node_timex_offset_seconds{%(nodeExporterSelector)s} > 0.05
and
node_timex_offset_seconds{%(nodeExporterSelector)s} < 1.0
and
deriv(node_timex_offset_seconds{%(nodeExporterSelector)s}[5m]) >= 0
)
or
(
node_timex_offset_seconds{%(nodeExporterSelector)s} < -0.05
and
node_timex_offset_seconds{%(nodeExporterSelector)s} > -1.0
and
deriv(node_timex_offset_seconds{%(nodeExporterSelector)s}[5m]) <= 0
)
Expand Down
Loading