collector/mountstats: add mountpoint label for NFS metrics#3554
Open
Vedant-Mhatre wants to merge 3 commits intoprometheus:masterfrom
Open
collector/mountstats: add mountpoint label for NFS metrics#3554Vedant-Mhatre wants to merge 3 commits intoprometheus:masterfrom
Vedant-Mhatre wants to merge 3 commits intoprometheus:masterfrom
Conversation
Signed-off-by: Vedant-Mhatre <vedantmh@gmail.com>
Signed-off-by: Vedant-Mhatre <vedantmh@gmail.com>
Vedant-Mhatre
force-pushed
the
feat/mountstats-mountpoint-label-2097
branch
from
9b9f366 to
f9def67
Compare
Signed-off-by: Vedant-Mhatre <vedantmh@gmail.com>
Vedant-Mhatre
force-pushed
the
feat/mountstats-mountpoint-label-2097
branch
from
f9def67 to
c6acf97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
mountpointlabel tomountstatsNFS metrics so the same export mounted at different mountpoints is represented as separate series.What changed
mountpointto mountstats NFS label sets (labels,opLabels,translabels)mountpointin dedup identity for NFS mount entriesmountpointthrough metric emission pathscollector/fixtures/proc/10/mountinfowithmountstatsfixture mountpointsmountpointlabel:collector/fixtures/e2e-output.txtcollector/fixtures/e2e-64k-page-output.txtWhy
Today, metrics are labeled by
export,protocol, andmountaddronly, which can collapse visibility when the same export is mounted multiple times.Adding
mountpointenables per-mount observability, as requested in #2097.Testing
go test ./...make common-check_license./end-to-end-test.sh(linux/arm64 fixture path)./end-to-end-test.sh(linux/amd64 fixture path)Note
There is an older open PR (#2676) for this issue that appears inactive; this PR is a fresh attempt with updated test and fixture alignment.