Open
Conversation
d45ed47 to
ebed2f0
Compare
Signed-off-by: Deezzir <deezzir@gmail.com>
ebed2f0 to
3780958
Compare
Author
|
@discordianfish and @SuperQ PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Add chip label to the
node_drm_card_infometric.Solution
Extend the DRM collector to have the
chiplabel from theClassDRMCardAMDGPUStats.The change was also proposed in the procfs repo, and the PR was merged.
Context
The DRM metrics are impossible to relate to the
hwmonmetrics, which export other helpful information about AMD GPUs. The extension will allow us to relate metrics from bothhwmonand 'drm` and, in turn, create a better GPU Dashboard for AMD with proper filtering and labelling.Example metrics: