OM2: Discontinue OM Proto; specify PrometheusProto#2836
Open
OM2: Discontinue OM Proto; specify PrometheusProto#2836
Conversation
94f1cc9 to
40185d0
Compare
krajorama
reviewed
Feb 18, 2026
Member
krajorama
left a comment
There was a problem hiding this comment.
LGTM, let's see dev summit response
bwplotka
commented
Feb 18, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
1c3163d to
a19a068
Compare
bwplotka
commented
Feb 24, 2026
|
|
||
| ### Basic info | ||
|
|
||
| | Aspect | Description | |
Member
Author
There was a problem hiding this comment.
FYI: Taken from historical, yet still up-to-date Matt P. document https://docs.google.com/document/d/1ZjyKiKxZV83VI9ZKAXRGKaUKK2BIWCT7oiGBKDBpjEY/edit?tab=t.0#heading=h.enginc5vuf3z
krajorama
reviewed
Feb 24, 2026
Comment on lines
+199
to
+201
| Ingestors SHOULD prioritize scraping Prometheus Proto for the future feature compatibility. This is not true for | ||
| Prometheus 3.0, which for backward compatibility prefers OpenMetrics 1.0 unless | ||
| * Manually changed in `scrape_protocols` setting |
Member
There was a problem hiding this comment.
What does "Ingestors" mean in this context ? If it's a program, then it's weird because then we say that Prometheus 3.0 doesn't do this. If it's a person, then why should they care? I'd say instead
Suggested change
| Ingestors SHOULD prioritize scraping Prometheus Proto for the future feature compatibility. This is not true for | |
| Prometheus 3.0, which for backward compatibility prefers OpenMetrics 1.0 unless | |
| * Manually changed in `scrape_protocols` setting | |
| Prometheus 3.0 will prioritize Prometheus Proto automatically when certain features are enabled, because some features are only supported with Prometheus Proto. |
Member
There was a problem hiding this comment.
Maybe also refer to "When to use Proto over Text?" section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/OpenMetrics#296
This proposes:
Proposed this to be a discussion on DevSummit https://docs.google.com/document/d/1uurQCi5iVufhYHGlBZ8mJMK_freDFKPG0iYBQqJ9fvA/edit?tab=t.0#bookmark=id.8x3p3zrx8mfu