protobuf: allow compiling without protoc#295
Open
howardjohn wants to merge 2 commits intoprometheus:masterfrom
Open
protobuf: allow compiling without protoc#295howardjohn wants to merge 2 commits intoprometheus:masterfrom
howardjohn wants to merge 2 commits intoprometheus:masterfrom
Conversation
Signed-off-by: John Howard <john.howard@solo.io>
Our goal is to have our builds compile without external dependencies. `protox` helps achieve this. Signed-off-by: John Howard <john.howard@solo.io>
Member
|
@howardjohn do I understand correctly, that you are actually using the Prometheus protobuf format? I wasn't aware of any users thus far, and was thus actually considering removing protobuf support all together from |
Contributor
Author
|
@mxinden no, I plan to adopt it though with the ultimate goal of getting native histograms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our goal is to have our builds compile without external dependencies.
protoxhelps achieve this.