Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
- perf: Remove truthy conditionals from default metric collectors
- fix: Preserve zero-valued Counter exemplars
- perf: Remove object and array fallback truthiness from core metric paths
- fix: use independent TDigest stores in TimeWindowQuantiles

### Added

Expand Down
5 changes: 4 additions & 1 deletion lib/timeWindowQuantiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ class TimeWindowQuantiles {

this.shouldRotate = maxAgeSeconds && ageBuckets;

this.ringBuffer = Array(ageBuckets).fill(new TDigest());
this.ringBuffer = Array.from(
{ length: ageBuckets || 1 },
() => new TDigest(),
);
this.currentBuffer = 0;

this.lastRotateTimestampMillis = Date.now();
Expand Down
8 changes: 8 additions & 0 deletions test/timeWindowQuantilesTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,13 @@ describe('timeWindowQuantiles', () => {
expect(td.centroids.size).toEqual(0);
});
});

it('should keep buckets independent during rotation', () => {
instance.push(0);
jest.advanceTimersByTime(1001);
instance.push(100);

expect(instance.percentile(0.5)).toEqual(50);
});
});
});