Skip to content

victorops: use Splunk On-Call branding - #5402

Open
gnanirahulnutakki wants to merge 1 commit into
prometheus:mainfrom
gnanirahulnutakki:gnanirahulnutakki/issue-3539-splunk-on-call
Open

victorops: use Splunk On-Call branding#5402
gnanirahulnutakki wants to merge 1 commit into
prometheus:mainfrom
gnanirahulnutakki:gnanirahulnutakki/issue-3539-splunk-on-call

Conversation

@gnanirahulnutakki

Copy link
Copy Markdown

Summary

  • update user-facing VictorOps branding to the current Splunk On-Call name
  • replace retired VictorOps documentation links with current official Splunk references
  • preserve all existing victorops_* configuration fields, notifier identifiers, metric labels, templates, package paths, and endpoint defaults

Validation

  • make common-format
  • make lint
  • make test

Pull Request Checklist

Please check all the applicable boxes.

  • Please list all open issue(s) discussed with maintainers related to this change
  • Is this a new Receiver integration?
  • Is this a bugfix?
    • I have added tests that can reproduce the bug which pass with this bugfix applied
  • Is this a new feature?
    • I have added tests that test the new feature's functionality
  • Does this change affect performance?
    • I have provided benchmarks comparison that shows performance is improved or is not degraded
      • You can use benchstat to compare benchmarks
    • I have added new benchmarks if required or requested by maintainers
  • Is this a breaking change?
    • My changes do not break the existing cluster messages
    • My changes do not break the existing api
  • I have added/updated the required documentation
  • I have signed-off my commits
  • I will follow best practices for contributing to this project

Which user-facing changes does this PR introduce?

[ENHANCEMENT] victorops: Use Splunk On-Call branding in user-facing documentation and errors while preserving existing configuration names.

Update user-facing documentation, source comments, and validation errors to use the current product name while preserving the existing VictorOps configuration and telemetry surface.

Assisted-by: OpenAI Codex
Signed-off-by: Gnani Rahul Nutakki <gnani.nutakki@gmail.com>
@gnanirahulnutakki
gnanirahulnutakki requested a review from a team as a code owner July 24, 2026 02:49
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 723b6bb8-7450-4d1c-be64-db9b05e1fb6d

📥 Commits

Reviewing files that changed from the base of the PR and between 949777a and ecd5483.

📒 Files selected for processing (8)
  • CHANGELOG.md
  • config/config.go
  • config/config_test.go
  • config/notifiers.go
  • config/notifiers_test.go
  • docs/configuration.md
  • docs/integrations.md
  • notify/victorops/victorops.go

📝 Walkthrough

Walkthrough

The change updates VictorOps user-facing documentation, comments, and validation errors to Splunk On-Call terminology while retaining existing victorops_* configuration names and validation behavior.

Changes

Splunk On-Call branding

Layer / File(s) Summary
Configuration validation messages
config/config.go, config/notifiers.go, config/*_test.go
Validation errors and matching tests now use Splunk On-Call wording without changing validation logic.
Integration configuration documentation
docs/configuration.md, docs/integrations.md
Documentation identifies Splunk On-Call, updates external links, and preserves VictorOps configuration names for compatibility.
Notifier terminology and release notes
notify/victorops/victorops.go, CHANGELOG.md
Notifier comments, API references, and the unreleased changelog entry use Splunk On-Call branding.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: updating VictorOps branding to Splunk On-Call.
Description check ✅ Passed The description follows the template well, includes the issue link, validation, checklist items, and release notes.
Linked Issues check ✅ Passed The PR satisfies #3539 by renaming user-facing VictorOps references to Splunk On-Call while preserving existing configuration names.
Out of Scope Changes check ✅ Passed The changes stay focused on branding, docs, errors, comments, tests, and changelog updates, with no clear unrelated additions.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename VictorOps to Splunk OnCall

2 participants