notify: add receiver and integration as structured log fields on failures

[locker95]

Pull Request Checklist

Please check all the applicable boxes.

• Please list all open issue(s) discussed with maintainers related to this change
  • Fixes Add receiver/integration (and where available, channel) as structured log fields on notification failures #5396
• Is this a new Receiver integration?
  • I have already tried to use the Webhook Receiver Integration and 3rd party integrations before adding this new Receiver Integration
• Is this a bugfix?
  • I have added tests that can reproduce the bug which pass with this bug fix applied
• Is this a new feature?
  • I have added tests that test the new feature's functionality
• Does this change affect performance?
  • I have provided benchmarks comparison that shows performance is improved or is not degraded
  • I have added new benchmarks if required or requested by maintainers
• Is this a breaking change?
  • My changes do not break the existing cluster messages
  • My changes do not break the existing api
• I have added/updated the required documentation
• I have signed-off my commits
• I will follow best practices for contributing to this project

Which user-facing changes does this PR introduce?

[ENHANCEMENT] notify: Add receiver and integration as structured log fields on notification failures

Summary

When a notification send fails, the dispatcher logs Notify for alerts failed with only aggrGroup, num_alerts, and err as structured fields. The receiver name and integration (e.g. slack[0]) are present only inside the free-text err string, which makes log aggregation (Loki/ELK) brittle.

Changes

• Introduce notify.ErrorWithIntegration to annotate RetryStage failures with receiver and integration
• Attach receiver (from the aggregation group) and integration (when available via errors.As) as structured fields on the dispatch failure log
• Extend RetryStage tests to assert the annotated error fields

Channel is intentionally out of scope here: it is integration-specific and already appears in some integration error messages (e.g. Slack). Receiver/integration alone cover the main operator need from #5396.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8090f1c8-a849-461d-8102-548f56c840fd

📥 Commits

Reviewing files that changed from the base of the PR and between 949777a and 49cc58b.

📒 Files selected for processing (4)

• dispatch/dispatch.go
• notify/notify_test.go
• notify/retry_stage.go
• notify/util.go

---

📝 Walkthrough

Walkthrough

Notification retry failures now include receiver and integration metadata through a new wrapped error type. Retry termination paths produce this error, and aggregation-group dispatch logging extracts the integration field for structured logs. Tests validate metadata for unrecoverable and canceled retries.

Changes

Notification failure context

Layer / File(s)	Summary
Error context contract notify/util.go	Adds ErrorWithIntegration, its constructor, and Error/Unwrap methods for preserving notification metadata and the underlying error.
Retry failure propagation notify/retry_stage.go, notify/notify_test.go	Wraps canceled and unrecoverable retry errors with receiver and integration identifiers, with tests asserting both metadata values.
Dispatcher structured logging dispatch/dispatch.go	Extracts ErrorWithIntegration from notification failures and adds the integration field to aggregation-group error logs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant NotificationAttempt
  participant RetryStage
  participant DispatcherLogger
  NotificationAttempt->>RetryStage: return notification error
  RetryStage->>RetryStage: wrap receiver and integration metadata
  RetryStage->>DispatcherLogger: return ErrorWithIntegration
  DispatcherLogger->>DispatcherLogger: add receiver and integration fields

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: structured receiver and integration fields on notification failures.
Description check	✅ Passed	The description follows the template well, includes the issue reference, checklist items, and release notes, and clearly explains the change.
Linked Issues check	✅ Passed	The PR satisfies #5396 by adding structured receiver and integration logging on notification failures; channel was optional and is intentionally omitted.
Out of Scope Changes check	✅ Passed	The changes stay within the issue scope, covering logging, error annotation, and tests without introducing unrelated behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}