Skip to content

docs: Correct PagerDuty default config - #5397

Open
britcey wants to merge 2 commits into
prometheus:mainfrom
britcey:patch-1
Open

docs: Correct PagerDuty default config #5397
britcey wants to merge 2 commits into
prometheus:mainfrom
britcey:patch-1

Conversation

@britcey

@britcey britcey commented Jul 20, 2026

Copy link
Copy Markdown

s/toJSON/toJson/

This bit a co-worker when adjusting the default template; sadly, not something that 'amtool check-config' will catch.

Pull Request Checklist

Please check all the applicable boxes.

  • Please list all open issue(s) discussed with maintainers related to this change
    • Fixes # N/A
  • Is this a new Receiver integration? No
  • Is this a bugfix? Yes
  • Is this a new feature? No
  • Does this change affect performance? No
  • Is this a breaking change? No
  • I have added/updated the required documentation
  • I have signed-off my commits
  • I will follow best practices for contributing to this project

Which User-Facing Changes Does This PR Introduce?

NONE

…SON'

s/toJSON/toJson/

This bit a co-worker when adjusting the default template;  sadly, not something that 'amtool check-config' will catch.

Signed-off-by: Ben Ritcey <ben+github@ritcey.com>
@britcey
britcey requested a review from a team as a code owner July 20, 2026 17:43
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8a20e952-f4e4-4182-8d77-503823cf92e3

📥 Commits

Reviewing files that changed from the base of the PR and between f5295c6 and 09d1bd9.

📒 Files selected for processing (1)
  • docs/configuration.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/configuration.md

📝 Walkthrough

Walkthrough

The PagerDuty receiver documentation updates the default details JSON template to use toJson for both firing and resolved alert data.

Changes

PagerDuty template documentation

Layer / File(s) Summary
Update PagerDuty details template
docs/configuration.md
The default PagerDuty details template now uses toJson for .Alerts.Firing and .Alerts.Resolved.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, in the requested area: short description form, and accurately summarizes the PagerDuty config fix.
Description check ✅ Passed The PR description covers the bugfix, checklist items, and release-notes section, matching the template with only minor non-critical omissions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants