Open
Conversation
Signed-off-by: Cody Kaczynski <ckaczyns@akamai.com>
Signed-off-by: Cody Kaczynski <ckaczyns@akamai.com>
8438d0a to
80ef37c
Compare
Signed-off-by: Cody Kaczynski <ckaczyns@akamai.com>
f30c992 to
4a0354e
Compare
Pre-compute hidden receivers set on config reload instead of iterating through all receivers on every isReceiverHidden check. This improves performance when filtering many alerts. Signed-off-by: Cody Kaczynski <ckaczyns@akamai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request does the following:
?includeHidden=trueto show "hidden" receivers in both UI and API responsesThis is set in the
receivers:block, like this:If unset, it will not be hidden.
Why?
This may be a niche usecase, but in our environment, we have a webhook receiver (internal tool) that is our top-level route, thus it receives every alert that reaches our Alertmanager cluster. This means that all alerts are essentially duplicated in the UI response when hitting the
/alertsendpoint.This makes the UI load a bit slower than we'd like, and other folks use the Alertmanager API for various automations and have been complaining of poor performance due to this (amongst other things).
Checklist