Skip to content

Add support for custom GitLab SSH endpoint#330

Merged
bastjan merged 3 commits intoprojectsyn:masterfrom
rxbn:master
Mar 19, 2026
Merged

Add support for custom GitLab SSH endpoint#330
bastjan merged 3 commits intoprojectsyn:masterfrom
rxbn:master

Conversation

@rxbn
Copy link
Copy Markdown
Contributor

@rxbn rxbn commented Feb 3, 2026

This pull request add support for a custom gitlab ssh endpoint url. I have already verified the changes in our environment.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

Copy link
Copy Markdown
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rxbn, thanks for the PR!

The change LGTM, but I'd like to have a second review from @bastjan.

Comment thread git/gitlab/gitlab.go Outdated
@simu simu requested a review from bastjan March 6, 2026 09:30
@simu simu added the enhancement New feature or request label Mar 6, 2026
Co-authored-by: Simon Gerber <gesimu@gmail.com>
Copy link
Copy Markdown
Member

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, a test for the custom parsing would not hurt.

Comment thread git/manager/manager.go
@simu simu changed the title feat: add support for custom ssh endpoint Add support for custom GitLab SSH endpoint Mar 19, 2026
Comment thread git/manager/manager_test.go Outdated
@bastjan bastjan merged commit e08cf47 into projectsyn:master Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants