Skip to content

fix: detect an expired kubeconfig and discard it from cache #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Aug 18, 2026
Merged

fix: detect an expired kubeconfig and discard it from cache #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions controllers/classifier_report_collection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,13 @@ func collectClassifierReportsFromCluster(ctx context.Context, c client.Client,
classifierReportList := libsveltosv1beta1.ClassifierReportList{}
err = clusterClient.List(ctx, &classifierReportList, listOptions...)
if err != nil {
// getClassifierClient succeeding only means the cached rest.Config was non-nil - it
// does not verify the credentials still work, since client.New performs no network
// call. A token that expired since the config was cached surfaces here, on first
// actual use, not there. Evict so the next collection cycle rebuilds the client from a
// freshly-read kubeconfig Secret instead of retrying the same stale credentials forever.
clustercache.GetManager().InvalidateOnAuthError(cluster.Namespace, cluster.Name,
clusterproxy.GetClusterType(cluster), err)
return err
}

Expand Down