Conversation
julienw
force-pushed
the
refine-type
branch
from
September 15, 2026 12:15
df3df82 to
44e103f
Compare
julienw
changed the title
julienw
force-pushed
the
refine-type
branch
from
September 15, 2026 12:28
44e103f to
326eddd
Compare
…ization classes constructor argument types
julienw
force-pushed
the
refine-type
branch
from
September 15, 2026 12:31
326eddd to
4542846
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the constructor was using a
Functionas the type, which isn't super precise and reduce type safety.So in this patch I suggest we make this a bit stricter. I also added types to other methods in the process, and made and
formatMessagesprotectedinstead ofprivate(it's used byDOMLocalization).