Repository navigation
Conversation
Contributor
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Linux workers with a cgroup memory cap can report host RAM to memguardian. In an isolated 256 MiB container, Nuclei saw 23.1% and kept low-memory mode off while cgroup usage was 78.4%.
Change
Use effective cgroup v1/v2 working-set usage and the most restrictive ancestor when below host RAM. Preserve host behavior for unlimited groups.
Proof
With this branch, the same Nuclei container entered low-memory mode at 80.0% actual cgroup use. Linux cgroup fixture tests passed in a network-disabled container; Linux arm64 vet and diff check passed.
This is a memory-safety prerequisite, not a measured scan-speed improvement. No production or DEV deployment is included.
Open in Codex: codex://threads/01a07d91-20ab-7a33-81ae-cfd2520595f4
Resume from CLI: codex resume 01a07d91-20ab-7a33-81ae-cfd2520595f4