Skip to content

chore: blocked - no usable tlsx tag to require - #2584

Draft
knakul853 wants to merge 2 commits into
devfrom
chore/tlsx-existing-tag
Draft

chore: blocked - no usable tlsx tag to require#2584
knakul853 wants to merge 2 commits into
devfrom
chore/tlsx-existing-tag

Conversation

@knakul853

@knakul853 knakul853 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Blocked on

  • tlsx needs a fresh, immutable tag. Every v1.3.x version is unusable, so there is nothing for this PR to point at - do not merge as-is.

Change

dev cannot be built by anyone whose GOPRIVATE routes projectdiscovery modules around the Go proxy: it requires tlsx v1.3.2, a tag deleted from GitHub (invalid version: unknown revision v1.3.2).

  • Moves the requirement to v1.3.0, which turns out to be insufficient - see Evidence.

Evidence

The v1.3.x line is broken two ways. v1.3.1 and v1.3.2 are absent from GitHub but cached in the proxy. v1.3.0 is worse: the proxy and sumdb recorded commit 0fad45b, while GitHub's tag now points at cd755a6 - the tag was moved after publication.

So CI fails with verifying github.com/projectdiscovery/tlsx@v1.3.0: checksum mismatch ... SECURITY ERROR. Recording either hash breaks the other audience, so no edit here can fix it. v1.2.2 is consistent and unaffected.

Still open

  • A new tag cut from the intended commit fixes both problems; this PR can then be repointed at it.
  • A retract block for v1.3.0/.1/.2 would stop them being selected again.

Claude-Session: https://claude.ai/code/session_015AKXsNzjd3HjGMq4B8JCNH
Claude-Local-Session: claude --resume 0fe5b680-5ba5-43e6-b354-43d4388aaf9c

tlsx v1.3.1 and v1.3.2 are cached in the Go module proxy but their tags
were deleted from GitHub, so anyone whose GOPRIVATE or GONOSUMDB routes
projectdiscovery modules around the proxy cannot resolve them:

    go: github.com/projectdiscovery/tlsx@v1.3.2: invalid version:
        unknown revision v1.3.2

v1.3.0 is a live tag whose commit is a descendant of the one v1.3.2
pointed at, so this loses nothing - the two share an identical go.mod
hash.

Claude-Session: https://claude.ai/code/session_015AKXsNzjd3HjGMq4B8JCNH
Claude-Local-Session: claude --resume 0fe5b680-5ba5-43e6-b354-43d4388aaf9c
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: cba3573c-54c6-4663-bdcb-d7d8a82e566c

📥 Commits

Reviewing files that changed from the base of the PR and between bdc5c33 and 7f5ba0f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The pull request downgrades the direct github.com/projectdiscovery/tlsx dependency from v1.3.2 to v1.3.0 in go.mod.

Changes

Dependency update

Layer / File(s) Summary
Update tlsx module requirement
go.mod
The direct github.com/projectdiscovery/tlsx requirement changes from v1.3.2 to v1.3.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7f5ba

This updates the tlsx dependency to an available tag and supplied validation confirms the project resolves and passes its checks. No current merge-blocking risk is identified.

Poem

I hop through modules neat and bright
A smaller version lands tonight
The go file keeps its steady tune
With tlsx set to one point three oh
My carrot marks the change just right

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title relates to the deleted tlsx tags that motivated the dependency change. It does not state the downgrade to v1.3.0, but it remains relevant and specific.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tlsx-existing-tag

Comment @coderabbitai help to get the list of available commands.

go.sum still carried hashes for the version that was replaced, which
left the module graph inconsistent and failed lint with "no go files to
analyze: running `go mod tidy` may solve the problem".

Claude-Session: https://claude.ai/code/session_015AKXsNzjd3HjGMq4B8JCNH
Claude-Local-Session: claude --resume 0fe5b680-5ba5-43e6-b354-43d4388aaf9c
@knakul853
knakul853 marked this pull request as draft September 5, 2026 20:06
@knakul853 knakul853 changed the title chore: require a tlsx version that exists on GitHub chore: blocked - no usable tlsx tag to require Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant