adds install rules to gnu/linux targets#110
adds install rules to gnu/linux targets#110hamgravy wants to merge 3 commits intoprojectNe10:masterfrom
Conversation
|
Hi, these patches work fine. However, the style of your code is quite different from Ne10. |
|
I created a new pull request with whitespace cleanup and I tested the install procedure |
|
Besides the formatting issues (resolved by @jeras in #134), these changes generally look good to me, with the caveat that I think the code for the uninstall procedure should be more formally attributed to its source. Particularly, the source licenses its content under CC BY 2.5, which outlines that this part of the patch should "give appropriate credit, provide a link to the license, and indicate if changes were made". |
|
Hi Joe, it seems you were given access to this repo, great. |
No description provided.