π‘οΈ Sentinel: Fix XSS vulnerability in invited room UI#773
π‘οΈ Sentinel: Fix XSS vulnerability in invited room UI#773kevinaboos wants to merge 1 commit intomainfrom
Conversation
This commit fixes a vulnerability where user-provided data (display name and user ID) was directly injected into HTML during the rendering of an invited room in the rooms list. The input is now safely sanitized using `htmlize::escape_text` before being formatted into the HTML string. Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in invited room UI
π¨ Severity: HIGH
π‘ Vulnerability: The user's display name and user ID were directly injected into an HTML string during the rendering of the
RoomsListEntrywhen an invitation was received. This could allow an attacker to execute arbitrary HTML/scripts within the client's context by setting a malicious display name or sending an invite from a specially crafted user ID.π― Impact: A malicious user could potentially break the UI rendering or execute unauthorized actions within the app's context by sending an invite with a crafted username.
π§ Fix: Sanitized the
display_nameanduser_idinputs usinghtmlize::escape_textbefore they are formatted and passed toshow_html().β Verification: Ran
cargo check,cargo test, andcargo clippywhich verified that the project compiles and passes all checks with the new sanitization in place.PR created automatically by Jules for task 8569256681624614964 started by @kevinaboos