Migrate to Makepad 2.0, from Live DSL to Splash script#761
Open
kevinaboos wants to merge 83 commits intoproject-robius:mainfrom
Open
Migrate to Makepad 2.0, from Live DSL to Splash script#761kevinaboos wants to merge 83 commits intoproject-robius:mainfrom
kevinaboos wants to merge 83 commits intoproject-robius:mainfrom
Conversation
Builds and runs, shows some of the Robrix UI but many major components are still missing
Fix some other stuff in SpaceLobby, though it's not yet fully working
SpacesBar is better, still not perfect.
Fix bare View usage to use SolidView/RoundedView instead when a `draw_bg` override is set. Fix shader instance/uniform usage
Seems that many script_apply_eval invocations are totally wrong
Turns out that Makepad's `AGENTS.md` has the incorrect syntax for this
Restore the icon ovveride in the invite_confirmation_modal
…he initial migration
(pending makepad-internal fixes from makepad/makepad#970)
…l re-do it later)
It still allows scrolling underneath it, but whatever.
…blocks) Select light theme on app startup
Member
Author
|
Moving ahead with the merge! The only known issues are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in mobile view mode has been tested due to the fact that AdaptiveView is not yet ported to Makepad 2.0.Seems to be fully working now!Widgets that are known to be working (via manual verification/fixes):
Actually this is still broken, waiting on a Makepad-level fix.Okay, now been fixed.Icon, improve to supportIconRotated, expose geom in draw_svg makepad/makepad#883)color_empty_hover/color_empty_focus are not being used.Fixed by me in TextInput: actually usecolor_empty_hover/focusin draw_text shader makepad/makepad#927TODO: check if this is the mainfixed: fix tooltip by force-drawing the draw list upon show/hide makepad/makepad#950Tooltipwidget or if it's a problem with ourCalloutTooltipwrapper/src/shared/animation does not runeverything working except unread badgefixed<br>tag obeys current line spacing settings makepad/makepad#971implemented but not fully testedfully workshoveranimator fordraw_icon, so thehoveranddowninstances used in RobrixIconButton'sdraw_iconshader actually never get modified.src/home/mostly works, just need to fix borders, and increase emoji font sizefully worksneeds a full reworkdonebuttons aren't aligned properlyfixedmostly working, except radio button selectionworksmissing some entry labels and iconsmissing some entry labels and iconsfixed now: fix SVG handling to support SVG files with fill "none" makepad/makepad#961but the styling code indoneupdate_preview_colors()was completely removed. Need to restore it.mostly working, except redraw isn't consistentseems to be fully working nowIt also does that old portal list behavior where scrolling upwards when you're at the bottom of the list will auto-jump to the top of the list.fixedsrc/login/src/logout/src/room/but bouncing dots is brokensrc/settings/log out button icon does not show properly (fixed by me: fix SVG handling to support SVG files with fill "none" makepad/makepad#961ICON_LOGOUT)src/profile/